-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workspace overview and update test cases #1446
Merged
Hailong-am
merged 3 commits into
opensearch-project:main
from
wanglam:remove-workspace-overview-and-update
Jul 31, 2024
Merged
Remove workspace overview and update test cases #1446
Hailong-am
merged 3 commits into
opensearch-project:main
from
wanglam:remove-workspace-overview-and-update
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
raintygao,
zhongnansu and
yujin-emma
as code owners
July 24, 2024 09:56
SuZhou-Joe
approved these changes
Jul 29, 2024
Workspace related test cases pass, safe to merge. |
Hailong-am
approved these changes
Jul 31, 2024
This was referenced Jul 31, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Remove overview update dropdown menu tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace create tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Add workspace detail test Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 66307da)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Remove overview update dropdown menu tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace create tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Add workspace detail test Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 66307da)
This was referenced Jul 31, 2024
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Remove overview update dropdown menu tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace create tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Add workspace detail test Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 66307da) Co-authored-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Remove overview update dropdown menu tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace create tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Add workspace detail test Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 66307da) Co-authored-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.