Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport main] [Security Analytics][2.15] Fix alerts tests security analytics #1404

Merged
merged 2 commits into from
Jun 14, 2024
Merged

[Backport main] [Security Analytics][2.15] Fix alerts tests security analytics #1404

merged 2 commits into from
Jun 14, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ff0a607 from #1402

@amsiglan @github-actions
[Security Analytics] Fix alerts tests security analytics (#1402)
bb77dd5 
Updates alerts spec test for PRs

Updated get findings & alerts to use duration filter and start showing results as they come in security-analytics-dashboards-plugin#1031
When sending partial alerts results extend them with the detector name and id as well security-analytics-dashboards-plugin#1033

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit ff0a607)
@SuZhou-Joe SuZhou-Joe merged commit d672ed0 into main Jun 14, 2024
56 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruanyl @SuZhou-Joe @amsiglan @Hailong-am