Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Don't need to force DatePickerMenu open #1367

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[Backport 2.x] Don't need to force DatePickerMenu open #1367

merged 1 commit into from
Jun 6, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2881c0f from #1358

@ananzh @github-actions
Don't need to force DatePickerMenu open (#1358)
d4468c8 
Due to opensearch-project/OpenSearch-Dashboards#6167,
we don't have the double render issue when global state is updated.

Therefore we don't need to call makeDatePickerMenuOpen function, which is just
to reclick the DatePickerToggle to make the menu re-open. This function is a tmp
solution to allow test passing.

In this PR, we will remove the function and all the usages.

Signed-off-by: Anan <ananzh@amazon.com>
(cherry picked from commit 2881c0f)
@ananzh ananzh merged commit 5eee691 into 2.x Jun 6, 2024
36 of 45 checks passed
@github-actions github-actions bot deleted the backport/backport-1358-to-2.x branch June 6, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ananzh