Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Dashboards Visualization Tests #1187

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Fix Flaky Dashboards Visualization Tests #1187

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a36a3c
fixing gantt chart flaky tests
sejli Mar 28, 2024
17deb74
Merge branch 'main' into gantt-charts-fix
sejli Mar 28, 2024
6314617
removing comments
sejli Mar 28, 2024
ebfd99d
Merge branch 'main' into gantt-charts-fix
sejli Mar 28, 2024
b987d13
try global tenant
sejli Mar 28, 2024
d4eebc5
try global tenant in before hook
sejli Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing comments 
Signed-off-by: Sean Li <lnse@amazon.com>
  • Loading branch information
@sejli
sejli committed Mar 28, 2024
commit 631461759174b481318f23e63adaa9c03eed8763
7 changes: 0 additions & 7 deletions cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,26 +59,19 @@ describe('Save a gantt chart', { defaultCommandTimeout: 20000 }, () => {
beforeEach(() => {
CURRENT_TENANT.newTenant = 'private';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we switch to a private tenant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to private tenant since some tests are flaky due to tennant popup. For some reason, setting it to global resulted in our target index not being found.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, switched over to global but it looks like the popup still stays there on the first test Create and saves a gantt chart. @SuZhou-Joe, any ideas on why the popup still shows up even after setting the tenant, and only on the first test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the tenant popup either. @kavilla Do you know how to hide the tenant popup?

cy.visit(`${BASE_PATH}/app/visualize#`);
// cy.wait(delay);
});

it('Creates and saves a gantt chart', () => {
cy.get('.euiButton__text').contains('Create ').click({ force: true });
// cy.wait(delay);
cy.get('[data-test-subj="visTypeTitle"]')
.contains('Gantt Chart')
.click({ force: true });
// cy.wait(delay);
cy.contains(/^jaeger$/).click({ force: true });
// cy.wait(delay);
cy.contains('Save').click({ force: true });
// cy.wait(delay);
cy.get('input[data-test-subj="savedObjectTitle"]').type(GANTT_VIS_NAME);
// cy.wait(delay);
cy.get('button[data-test-subj="confirmSaveSavedObjectButton"]').click({
force: true,
});
// cy.wait(delay);

cy.contains('Saved').should('exist');
});
Expand Down
Loading