Refactor 6_notebooks.spec.js #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
kavilla
approved these changes
Mar 26, 2024
Hailong-am
approved these changes
Mar 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Refactor 6_notebooks.spec.js Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify reporting integration before-each Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Avoid using this on notebook name access Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 8ec090c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Refactor 6_notebooks.spec.js Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify reporting integration before-each Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Avoid using this on notebook name access Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 8ec090c)
Hailong-am
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Refactor 6_notebooks.spec.js Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify reporting integration before-each Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Avoid using this on notebook name access Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 8ec090c) Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Hailong-am
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Refactor 6_notebooks.spec.js Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify reporting integration before-each Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Avoid using this on notebook name access Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 8ec090c) Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
* Refactor 6_notebooks.spec.js Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify reporting integration before-each Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Avoid using this on notebook name access Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from the autocut issue opensearch-project/dashboards-observability#1579: the tests for notebooks are failing in 2.13. This test suite has been flaky for a while, and it looked like the reason this one was failing was because some other delete action was interfering with the test (it was looking for a notebook but there was an empty notebook state).
This PR completely refactors these tests to be mutually independent: every test gets its own notebook with a randomized name, and each notebook has its own teardown. This should help avoid all the weird interdependent flakiness from before with this suite.
Needs backporting to 2.x and 2.13.
Issues Resolved
opensearch-project/dashboards-observability#1579
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.