Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboards assistant trace button functional test #1149

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Mar 18, 2024

Description

  1. update cypress functional test for dashboards assistant trace icon change.
  2. update to latest security demo cert

Issues Resolved

opensearch-project/dashboards-assistant#158

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the cert but did security team change he cert manually in every release?

@SuZhou-Joe
Copy link
Member

Find the context in opensearch-project/security#4061, and it seems the cert will be valid in 10 years.

@SuZhou-Joe SuZhou-Joe merged commit 4d51788 into opensearch-project:main Mar 18, 2024
42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2024
* update view trace button of dashboards assitant

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update to latest cert

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 4d51788)
Hailong-am added a commit that referenced this pull request Mar 18, 2024
* update view trace button of dashboards assitant

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update to latest cert

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 4d51788)

Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants