-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Analytics] Add force type option to avoid element getting covered error #1102
Merged
kavilla
merged 1 commit into
opensearch-project:2.12
from
amsiglan:update-flaky-rules-test
Feb 16, 2024
Merged
[Security Analytics] Add force type option to avoid element getting covered error #1102
kavilla
merged 1 commit into
opensearch-project:2.12
from
amsiglan:update-flaky-rules-test
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
February 16, 2024 22:30
kavilla
approved these changes
Feb 16, 2024
amsiglan
added a commit
to amsiglan/opensearch-dashboards-functional-test
that referenced
this pull request
May 9, 2024
…d error (opensearch-project#1102) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detection text area gets covered by the breadcrumbs element due to which cypress throws when trying to type. Adding
force
option to avoid throwing error since it doesn't affect the behavior.Issues Resolved
opensearch-project/security-analytics-dashboards-plugin#857
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.