Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing Confirmation] Confirm current testing requirements #546

Closed
stephen-crawford opened this issue Feb 20, 2023 · 4 comments
Closed
Labels
enhancement New feature or request untriaged

Comments

@stephen-crawford
Copy link

stephen-crawford commented Feb 20, 2023

As part of the discussion around implementing an organization-wide testing policy, I am visiting each repo to see what tests they currently perform. I am conducting this work on GitHub so that it is easy to reference.

Looking at the OpenSearch Dashboards Functional Test repository, it appears there is

Repository Unit Tests Integration Tests Backwards Compatibility Tests Additional Tests Link
OpenSearch Dashboards Functional Test
  • Link Checker, Lint, Bundled Tests, tests added from other repositories #546

    I don't see any requirements for code coverage in the testing documentation. If there are any specific requirements could you respond to this issue to let me know?

    If there are any tests I missed or anything you think all repositories in OpenSearch should have for testing please respond to this issue with details.

    @ashwin-pc
    Copy link
    Member

    The BWC tests for OSD reside in the OSD repo itself. @kavilla Should we move them here so that we dont have to have a complicated test structure?

    @kavilla
    Copy link
    Member

    kavilla commented Mar 3, 2023

    I think so. We can also take the change the to clean them up too since they are duplicated to handle with security and without security.

    @stephen-crawford
    Copy link
    Author

    Hi @ashwin-pc and @kavilla, thank you for following up. I will update the notes to show your change. Let me know if there is anything else I should address.

    @seraphjiang
    Copy link
    Member

    this repo is not plugin repo, not applicable to the policy. in the future if we create repo like load-testing, it should be excluded as well.

    thanks @scrawfor99 for check, and thanks @ashwin-pc and @kavilla for triage. closing the issue.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    enhancement New feature or request untriaged
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants