Upgrade aws-cdk-lib to latest 2.134.0 version #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
rishabh6788
commented
Apr 3, 2024
bin/ci-stack.ts
Outdated
| const ciStack = new CIStack(app, `OpenSearch-CI-${defaultEnv}`, {}); | ||
| const ciStack = new CIStack(app, `OpenSearch-CI-${defaultEnv}`, { | ||
| env: { | ||
| region: 'us-east-1', |
There was a problem hiding this comment.
This is required while enabling VPC Flow logs. Without this build will succeed but cdk targets will fail.
Signed-off-by: Rishabh Singh <sngri@amazon.com>
| @@ -31,7 +31,7 @@ export class ArtifactsPublicAccess { | |||
| })); | |||
|
|
|||
| const urlRewriter = new NodejsFunction(stack, 'CfUrlRewriter', { | |||
| runtime: Runtime.NODEJS_14_X, | |||
| runtime: Runtime.NODEJS_16_X, | |||
There was a problem hiding this comment.
node16 is already eol and consider it is very similar with node18, can we just move to node18 here?
peterzhuamazon
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
aws-cdk-liblibrary version to latest 2.134.0 version.Issues Resolved
#396
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.