Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Copyright headers #948

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Nov 11, 2021

Signed-off-by: Owais Kazi owaiskazi19@gmail.com

Description

Updated copyright headers

Issues Resolved

#152

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 requested a review from a team as a code owner November 11, 2021 22:59
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

# express or implied. See the License for the specific language governing
# permissions and limitations under the License.
# Modifications Copyright OpenSearch Contributors. See
# GitHub history for details.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned here #152 (comment). Files like this should only have

# Copyright OpenSearch Contributors
# SPDX-License-Identifier: Apache-2.0

Can someone check here if the header is correct? Just wanted to confirm once

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbarani @peterzhuamazon can you verify. Looks like the second one is for For files that contain attribution to an external project

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informed Miki to verify once as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets follow this rule,
First Remove the amazon header

    • if there is no header left, use the 2-liner
    • If there are other headers, use the long one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one that I use and confirmed by Open Source Team:


# SPDX-License-Identifier: Apache-2.0
#
# The OpenSearch Contributors require contributions made to
# this file be licensed under the Apache-2.0 license or a
# compatible open source license.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the plugins teams have followed

# Copyright OpenSearch Contributors
# SPDX-License-Identifier: Apache-2.0

I would suggest let's have the same for consistency and as mentioned by Miki over here #152 (comment)

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@dblock dblock merged commit 805fbec into opensearch-project:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants