-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved contents of bundle-workflow to the root. #678
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 72 72
Lines 1918 1918
=======================================
Hits 1680 1680
Misses 238 238 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many changes!
Signed-off-by: dblock <dblock@dblock.org>
I will hold this until 1.1.0 release is out in case any issues caused in the process. |
Rather than block this PR, could we lock on the jenkins build job to a commit/branch? @peterzhuamazon |
We will create branch/tag after the launch. |
I don't feel strongly that we should be branching, so happy to hold this till we release 1.1. |
Install dependencies. | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few left overs of bundle-workflow in TOC and in some sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
Thanks @dblock !
Signed-off-by: dblock dblock@dblock.org
Description
This repository is dedicated to the building a complete OpenSearch distribution, thus it doesn't make sense to have a
bundle-workflow
directory. This PR moves it up, fixes all the paths, updates READMEs, etc. There are no code changes here, it's mostly agit mv
, plus adjusted paths and merged README.I was able to run a clean build of OpenSearch 1.1 with these changes.
Issues Resolved
Closes #448.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.