Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved contents of bundle-workflow to the root. #678

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 4, 2021

Signed-off-by: dblock dblock@dblock.org

Description

This repository is dedicated to the building a complete OpenSearch distribution, thus it doesn't make sense to have a bundle-workflow directory. This PR moves it up, fixes all the paths, updates READMEs, etc. There are no code changes here, it's mostly a git mv, plus adjusted paths and merged README.

I was able to run a clean build of OpenSearch 1.1 with these changes.

Issues Resolved

Closes #448.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #678 (c05a289) into main (c2687b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          72       72           
  Lines        1918     1918           
=======================================
  Hits         1680     1680           
  Misses        238      238           
Impacted Files Coverage Δ
src/assemble_workflow/bundle.py 97.01% <ø> (ø)
src/assemble_workflow/bundle_opensearch.py 100.00% <ø> (ø)
.../assemble_workflow/bundle_opensearch_dashboards.py 100.00% <ø> (ø)
src/assemble_workflow/bundle_recorder.py 100.00% <ø> (ø)
src/assemble_workflow/bundles.py 100.00% <ø> (ø)
src/aws/s3_bucket.py 95.23% <ø> (ø)
src/build_workflow/build_args.py 100.00% <ø> (ø)
src/build_workflow/build_artifact_check.py 90.90% <ø> (ø)
src/build_workflow/build_artifact_checks.py 100.00% <ø> (ø)
src/build_workflow/build_recorder.py 100.00% <ø> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2687b3...c05a289. Read the comment docs.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many changes!

ONBOARDING.md Show resolved Hide resolved
Signed-off-by: dblock <dblock@dblock.org>
@peterzhuamazon
Copy link
Member

I will hold this until 1.1.0 release is out in case any issues caused in the process.
Otherwise I have no more objection here.
Thanks.

@peternied
Copy link
Member

peternied commented Oct 5, 2021

I will hold this until 1.1.0 release is out in case any issues caused in the process. Otherwise I have no more objection here. Thanks.

Rather than block this PR, could we lock on the jenkins build job to a commit/branch? @peterzhuamazon

@peterzhuamazon
Copy link
Member

I will hold this until 1.1.0 release is out in case any issues caused in the process. Otherwise I have no more objection here. Thanks.

Rather than block this PR, could we lock on the jenkins build job to a commit/branch? @peterzhuamazon

We will create branch/tag after the launch.
And I dont think it is a good idea to introduce this big of a structure change right now.

@dblock
Copy link
Member Author

dblock commented Oct 5, 2021

I don't feel strongly that we should be branching, so happy to hold this till we release 1.1.

Comment on lines 70 to 72
Install dependencies.

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few left overs of bundle-workflow in TOC and in some sections.

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
Thanks @dblock !

@peterzhuamazon peterzhuamazon merged commit 386b779 into opensearch-project:main Oct 6, 2021
@dblock dblock deleted the move-to-root branch October 7, 2021 00:03
@dblock dblock restored the move-to-root branch October 13, 2021 14:48
@dblock dblock deleted the move-to-root branch October 13, 2021 14:48
@dblock dblock restored the move-to-root branch October 13, 2021 14:49
@dblock dblock deleted the move-to-root branch October 13, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move bundle-workflow a directory up
5 participants