Skip to content

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Sep 24, 2021

Description

Add Jenkins Docker Parallel Support and Restructure CICD Environment for build/assemble/test

  1. Modify Dockerfile to include necessary dependencies, include both x64 and arm64 build capability. Remove JDK and MAVEN as Jenkins dependencies, add to dockerfile
  2. Added centos alongside the original al2 base image, as k-NN needs to be built on CentOS for older glibc version (2.26 vs 2.17) than the one on al2.
  3. Upload docker images based on the dockerfiles to https://hub.docker.com/r/opensearchstaging/ci-runner.
  4. Removed tools/standard-* folders as they are obsolete with the introduction of https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow/src/test_workflow.
  5. Move the standard deploy single node cluster script to scripts/ folder as it is still handy to use for testing on local.
  6. Move all the dockerfiles to bundle-workflow/ folder as they are used for all bundle related actions.
  7. Added entries to README and Documentations for usages.

Thanks.

Issues Resolved

#399 #209 opensearch-project/opensearch-infra#109

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…for build/assemble/test

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #588 (59c5f79) into main (0badd64) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files          61       61           
  Lines        1672     1672           
=======================================
  Hits         1425     1425           
  Misses        247      247           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0badd64...59c5f79. Read the comment docs.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great step forward, I would 🚢 it.

@peterzhuamazon peterzhuamazon marked this pull request as ready for review September 24, 2021 16:06
peternied
peternied previously approved these changes Sep 24, 2021
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great - none of my questions are blocking, but I'd love more details

…nstallation

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peternied
peternied previously approved these changes Sep 24, 2021
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Hi @dblock @gaiksaya please check and approve, comment if you still have any concerns. Thanks.
I also add a new line of code to allow docker adding env var for JAVA_HOME.
This will unblock k-NN lib make issues as jni.ini is not found.

Thanks.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder whether we have something to learn from the likes of GitHub actions which don’t include Java or Maven in base images. This makes it easy to test matrixes of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build process should use multiple agent nodes in parallel Dockerize component build scripts
6 participants