Adding component onboarding README #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 77.48% 82.96% +5.48%
==========================================
Files 59 59
Lines 1612 1614 +2
==========================================
+ Hits 1249 1339 +90
+ Misses 363 275 -88
Continue to review full report at Codecov.
|
dblock
previously approved these changes
Sep 22, 2021
ONBOARDING.md
Outdated
| 1. It supports two test configs - `with-security` and `without-security`, which runs test with security plugin enabled and disabled respectively. Choose one or both depending on what your plugin integration tests support. | ||
| 2. If your plugin is dependent on `job-scheduler` zip, you can define that in `build-dependencies` in the config. Currently, the test workflow only supports `job-scheduler` as build dependency. Please create an issue if your plugin needs more support. | ||
|
|
||
| 3. For backward compatibility testing, the `test-workflow` runs backward compatibility tests available in the plugin repository. Like integration test, it has a set of configurable options defined in test_manifest.yml, [example](https://github.com/opensearch-project/opensearch-build/blob/85bbe204e947d5d1579af771bbafe399c11cbd70/bundle-workflow/src/test_workflow/config/test_manifest.yml#L3) |
1 task
Signed-off-by: Himanshu Setia <setiah@amazon.com>
dblock
approved these changes
Sep 23, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Himanshu Setia setiah@amazon.com
Issues Resolved
#558
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.