Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard query-insights in 2.16 #4861

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

deshsidd
Copy link
Contributor

Completing based on the following PR : #4856

Description
This PR onboards query insights plugin in 2.16.

It bundles query-insights in 2.16 components so that opensearch 2.16 distribution will have query insights by default.
Add query insights in os-increment-plugin-versions and os-release-issues workflows.
Issues Resolved
related to #4826

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ansjcy and others added 2 commits July 16, 2024 16:41
Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd
Copy link
Contributor Author

Made the changes as requested by @gaiksaya. Please review @gaiksaya @peterzhuamazon @prudhvigodithi

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (aefb420) to head (210fced).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4861      +/-   ##
==========================================
+ Coverage   92.05%   92.31%   +0.26%     
==========================================
  Files         193      193              
  Lines        6416     6445      +29     
==========================================
+ Hits         5906     5950      +44     
+ Misses        510      495      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi
Copy link
Collaborator

Thanks @deshsidd, from the PR I see the query insights plugin has no dependencies (depends_on) on other plugins, is this true?

@gaiksaya gaiksaya added the manifest-ci-check Run manifest ci check label Jul 18, 2024
@deshsidd
Copy link
Contributor Author

Can someone re-trigger the whitesource security check please ?

@deshsidd
Copy link
Contributor Author

Thanks @deshsidd, from the PR I see the query insights plugin has no dependencies (depends_on) on other plugins, is this true?

Yes, we have no dependencies as of now. Thanks

@gaiksaya gaiksaya merged commit e0a9177 into opensearch-project:main Jul 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants