Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split osd core test into ci groups #4784

Closed
wants to merge 2 commits into from
Closed

feat: split osd core test into ci groups #4784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb9c067
feat: split osd core test into ci groups
SuZhou-Joe Jun 17, 2024
1acee14
feat: split osd core test into ci groups
SuZhou-Joe Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jenkins/opensearch-dashboards/integ-test.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ pipeline {
echo "componentList: ${componentList}"

for (component_check in componentList) {
if (!componentDefaultList.contains(component_check)) {
if (!componentDefaultList.contains(component_check) && !component_check.startsWith("OpenSearch-Dashboards-ci-group-")) {
error("${component_check} is not in build manifest: ${componentDefaultList}, exit 1")
}
}
Expand Down
106 changes: 105 additions & 1 deletion manifests/2.15.0/opensearch-dashboards-2.15.0-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,111 @@ ci:
image:
name: opensearchstaging/ci-runner:ci-runner-rockylinux8-opensearch-dashboards-integtest-v4
components:
- name: OpenSearch-Dashboards
- name: OpenSearch-Dashboards-ci-group-1
Copy link
Member

@gaiksaya gaiksaya Jun 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would throw error saying component not found as there is a mismatch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good from the python side as it only checks test manifest and gets list of components. If we can handle it from Jenkinsfile side as mentioned in my comment below then we are good. Right?

integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-2
integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SuZhou-Joe may I know what tests or components part of these groups ? example for OpenSearch-Dashboards-ci-group-3, coming from this PR https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1411/files, how to know what tests or components are part of OpenSearch-Dashboards-ci-group-3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specs are written in the package.json.
https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/package.json#L28-L36

Copy link
Member

@prudhvigodithi prudhvigodithi Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get this change documentation somewhere (may be in https://github.com/opensearch-project/opensearch-build/wiki/Testing-the-Distribution).
Thanks

integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-4
integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-5
integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-6
integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-7
integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-8
integ-test:
test-configs:
- with-security
- without-security
additional-cluster-configs:
vis_builder.enabled: true
data_source.enabled: true
savedObjects.maxImportPayloadBytes: 10485760
server.maxPayloadBytes: 1759977
logging.json: false
data.search.aggs.shardDelay.enabled: true
csp.warnLegacyBrowsers: false
- name: OpenSearch-Dashboards-ci-group-9
integ-test:
test-configs:
- with-security
Expand Down
Loading