Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opensearch 2.12.0/1.3.15 checks as distribution-build already taken care of issue reporting #4381

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jan 29, 2024

Description

Remove opensearch 2.12.0/1.3.15 checks as distribution-build already taken care of issue reporting

This is step 1 to add all components in the manifest all together.

Issues Resolved

Part of #3707 #4389

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…are of issue reporting

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…are of issue reporting

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention in the PR description that this is step 1 to add all components in the manifest all together.
Also do you plan to disable the check workflow in this PR or another PR? https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/manifests.yml

@peterzhuamazon
Copy link
Member Author

Please mention in the PR description that this is step 1 to add all components in the manifest all together. Also do you plan to disable the check workflow in this PR or another PR? https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/manifests.yml

Do we want to keep the check just to ensure that manifest itself is syntax valid?

@gaiksaya
Copy link
Member

Please mention in the PR description that this is step 1 to add all components in the manifest all together. Also do you plan to disable the check workflow in this PR or another PR? https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/manifests.yml

Do we want to keep the check just to ensure that manifest itself is syntax valid?

We do have yaml lint workflow to check the lint. Maybe we can keep for now and then eventually phase out.

@peterzhuamazon peterzhuamazon merged commit 8e98c76 into opensearch-project:main Jan 30, 2024
11 checks passed
@peterzhuamazon peterzhuamazon deleted the remove-ci-checks-manifests branch January 30, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants