Refactor distribution-build.jenkinsfile for opensearch-dashboards #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Lu <chunglu@amazon.com>
jordarlu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4371 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6179 6179
=======================================
Hits 5645 5645
Misses 534 534 ☔ View full report in Codecov by Sentry. |
jordarlu
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
gaiksaya
reviewed
Jan 25, 2024
| @@ -1104,3 +1054,36 @@ def markStageUnstableIfPluginsFailedToBuild() { | |||
| unstable('Some plugins failed to build. See the ./build.sh step for logs and more details') | |||
| } | |||
| } | |||
|
|
|||
| def triggerIntegrationTests(String buildManifestUrl, String buildManifestUrlOpenSearch) { | |||
| Boolean skipIntegTests = (INTEG_TEST_JOB_NAME == '' || TEST_MANIFEST == '' || buildManifestUrl == '') | |||
There was a problem hiding this comment.
Please add a null check for buildManifestUrlOpenSearch as well.
Thanks!
There was a problem hiding this comment.
Thanks for noticing that,, adding it now.
Signed-off-by: Jeff Lu <chunglu@amazon.com>
rishabh6788
approved these changes
Jan 25, 2024
prudhvigodithi
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring distribution-build.jenkinsfile for opensearch-dashboards by reducing repetitive code
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.