Run integtest for components present in test manifest #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
dblock,
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6175 6175
=======================================
Hits 5641 5641
Misses 534 534 ☔ View full report in Codecov by Sentry. |
rishabh6788
reviewed
Jan 17, 2024
| @@ -7,30 +7,30 @@ | |||
| * compatible open source license. | |||
| */ | |||
|
|
|||
| lib = library(identifier: 'jenkins@5.11.1', retriever: modernSCM([ | |||
| lib = library(identifier: 'jenkins@add-getNames', retriever: modernSCM([ | |||
There was a problem hiding this comment.
Why are we deviating from semver here?
There was a problem hiding this comment.
No was waiting for opensearch-project/opensearch-build-libraries#361 to merge and cut a tag to be used. Else the tests would fail here.
There was a problem hiding this comment.
Upgraded the version and git repo to right version now.
Thanks!
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
|
|
||
| $class: 'GitSCMSource', | ||
| remote: 'https://github.com/opensearch-project/opensearch-build-libraries.git', | ||
| remote: 'https://github.com/gaiksaya/opensearch-build-libraries.git', |
peterzhuamazon
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change does the following:
This saves resources in the CI where a stage is deployed and skipped because the components was absent. Also avoids creation of unnecessary issues in the component repos.
Issues Resolved
resolves #3461
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.