Support security demo script changes

[rishabh6788]

Description

There were recent changes to security demo configuration setup which now requires a custom admin Password to be setup for OpenSearch version 2.12.0 and above.
This PR adds appropriate code changes to support the nightly benchmark runs.

Issues Resolved

opensearch-project/security#3624

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f92f571) 91.26% compared to head (0eccf7f) 91.27%.

Files	Patch %	Lines
..._workflow/benchmark_test/benchmark_test_cluster.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4304   +/-   ##
=======================================
  Coverage   91.26%   91.27%           
=======================================
  Files         189      189           
  Lines        6124     6140   +16     
=======================================
+ Hits         5589     5604   +15     
- Misses        535      536    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gaiksaya]

Can you please make sure piplock is not updating all other versions as well? And only the necessary package is installed?

[rishabh6788]

Can you please make sure piplock is not updating all other versions as well? And only the necessary package is installed?

I only added the new version, I am not sure how I can stop pipenv to not update other dependencies. I believe we have appropriate version restrictions on each requirements and pipenv honors that while updating. Should be safe.

[gaiksaya]

Can you please make sure piplock is not updating all other versions as well? And only the necessary package is installed?

I only added the new version, I am not sure how I can stop pipenv to not update other dependencies. I believe we have appropriate version restrictions on each requirements and pipenv honors that while updating. Should be safe.

Sometimes that break too. Mostly because of the underlying docker images during runs being different depending on the platform. We can merge this as if and monitor for any failures.

[gaiksaya]

Can we try with 2.3.0? 😅

[rishabh6788]

:) Done!

[gaiksaya]

Looks like code cov is complaining about need_strong_password. Maybe just add a small assert for that? Looks good overall. Need to get similar change in for cluster cdk as well.

[rishabh6788]

Looks like code cov is complaining about need_strong_password. Maybe just add a small assert for that? Looks good overall. Need to get similar change in for cluster cdk as well.

Yeah, it can nit-picky. The condition is actually tested in tests/tests_test_workflow/test_benchmark_workflow/benchmark_test/test_benchmark_test_suite.py where I am asserting a string password is present in the docker command.