Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS Upgrade] Add node@16.20.0 for build and node@18.16.0 / cypress@12.13.0 for OSD integTest #3552

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 24, 2023

Description

[NodeJS Upgrade] Add node@16.20.0 for build and node@18.16.0 / cypress@12.13.0 for OSD integTest

Issues Resolved

#1563
opensearch-project/opensearch-dashboards-functional-test#408
#3434

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… integTest

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #3552 (80cc745) into main (e33c997) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3552   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         181      181           
  Lines        5369     5369           
=======================================
  Hits         4912     4912           
  Misses        457      457           

@peterzhuamazon peterzhuamazon merged commit 6ccfd23 into opensearch-project:main May 24, 2023
@peterzhuamazon peterzhuamazon deleted the node16_cypress12_upgrade branch May 24, 2023 19:22
peterzhuamazon added a commit to peterzhuamazon/opensearch-build that referenced this pull request May 24, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

The cypress builds failed and a new fix here:

peterzhuamazon added a commit that referenced this pull request May 25, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the title Add node@16.20.0 for build and node@18.16.0 / cypress@12.13.0 for OSD integTest [NodeJS Upgrade] Add node@16.20.0 for build and node@18.16.0 / cypress@12.13.0 for OSD integTest Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants