Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amd64 as a condition for system/os.py to support freebsd x64 architecture #3240

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

peterzhuamazon
Copy link
Member

Description

Add amd64 as a condition for system/os.py to support freebsd x64 architecture

Issues Resolved

#3236

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…itecture

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added bug Something isn't working good first issue Good for newcomers labels Feb 24, 2023
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner February 24, 2023 05:39
@peterzhuamazon peterzhuamazon self-assigned this Feb 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #3240 (fcc184e) into main (214113e) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3240   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         167      167           
  Lines        4622     4622           
=======================================
  Hits         4308     4308           
  Misses        314      314           
Impacted Files Coverage Δ
src/system/os.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock dblock merged commit 76cc42d into opensearch-project:main Feb 28, 2023
@peterzhuamazon peterzhuamazon deleted the fix-system-os-bsd branch April 4, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants