Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k-NN 1.3 manifest to 1.x #1704

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

jmazanec15
Copy link
Member

Updates k-NN manifest to 1.x for 1.3 release. We recently setup main to
develop against 2.0, causing 1.3 build to break.

Related commit: opensearch-project/k-NN@b22a2dc

@gaiksaya - anywhere else I would need to update?

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Updates k-NN manifest to 1.x for 1.3 release. We recently setup main to
develop against 2.0, causing 1.3 build to break.

Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 requested a review from a team as a code owner March 3, 2022 22:07
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that's all the change we need.
Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #1704 (63ea0ca) into main (a7393c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1704   +/-   ##
=========================================
  Coverage     94.76%   94.76%           
  Complexity       14       14           
=========================================
  Files           168      168           
  Lines          3512     3512           
  Branches         26       26           
=========================================
  Hits           3328     3328           
  Misses          181      181           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7393c3...63ea0ca. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants