Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name and update file location for test manifest #1163

Merged
merged 4 commits into from
Nov 26, 2021

Conversation

tianleh
Copy link
Member

@tianleh tianleh commented Nov 26, 2021

Signed-off-by: Tianle Huang tianleh@amazon.com

Description

To distinguish the test manifest file for OpenSearch and OpenSearchDashboards, introduce the name attribute. Move it under a subfolder to allow co-exist. This will later used to instantiate different test clusters based on this name attribute. (part of #604 )

Issues Resolved

Resolves #1161

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
@tianleh tianleh requested a review from a team as a code owner November 26, 2021 07:28
@tianleh tianleh self-assigned this Nov 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #1163 (d055c0b) into main (f6a46b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1163   +/-   ##
=========================================
  Coverage     93.71%   93.72%           
  Complexity       10       10           
=========================================
  Files           100      100           
  Lines          2547     2548    +1     
  Branches          9        9           
=========================================
+ Hits           2387     2388    +1     
  Misses          150      150           
  Partials         10       10           
Impacted Files Coverage Δ
src/manifests/test_manifest.py 100.00% <100.00%> (ø)
src/run_integ_test.py 92.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a46b1...d055c0b. Read the comment docs.

@tianleh
Copy link
Member Author

tianleh commented Nov 26, 2021

An output from the integ rest run.


2021-11-26 08:47:46 INFO     | alerting             | with-security        | PASS  |    0 |
2021-11-26 08:47:46 INFO     | alerting             | without-security     | PASS  |    0 |
2021-11-26 08:47:46 INFO     | anomaly-detection    | with-security        | PASS  |    0 |
2021-11-26 08:47:46 INFO     | anomaly-detection    | without-security     | PASS  |    0 |
2021-11-26 08:47:46 INFO     | asynchronous-search  | with-security        | PASS  |    0 |
2021-11-26 08:47:46 INFO     | asynchronous-search  | without-security     | PASS  |    0 |
2021-11-26 08:47:46 INFO     | dashboards-reports   | without-security     | PASS  |    0 |
2021-11-26 08:47:46 INFO     | index-management     | with-security        | PASS  |    0 |
2021-11-26 08:47:46 INFO     | index-management     | without-security     | PASS  |    0 |
2021-11-26 08:47:46 ERROR    | k-NN                 | with-security        | FAIL  |    1 |
2021-11-26 08:47:46 INFO     | k-NN                 | without-security     | PASS  |    0 |
2021-11-26 08:47:46 INFO     | sql                  | with-security        | PASS  |    0 |
2021-11-26 08:47:46 INFO     | sql                  | without-security     | PASS  |    

@dblock dblock merged commit b798a0c into opensearch-project:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update name and location of test manifest file
4 participants