Publish the failing test's name and class along with the integration test results #536
Conversation
prudhvigodithi
requested review from
peterzhuamazon,
gaiksaya,
rishabh6788,
Divyaasm and
zelinh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=========================================
Coverage 84.72% 84.72%
Complexity 105 105
=========================================
Files 115 115
Lines 648 648
Branches 71 71
=========================================
Hits 549 549
Misses 29 29
Partials 70 70 ☔ View full report in Codecov by Sentry. |
prudhvigodithi
force-pushed
the
main
branch
7 times, most recently
from
ce7b797
to
670066f
Compare
vars/publishIntegTestResults.groovy
Outdated
| fi | ||
| fi | ||
| if [ -s ${testFailuresFile} ]; then | ||
| echo "File Exists, indexing results." |
There was a problem hiding this comment.
nit:
| echo "File Exists, indexing results." | |
| echo "File Exists, indexing failed tests." |
vars/publishIntegTestResults.groovy
Outdated
| @@ -224,6 +397,34 @@ void indexFailedTestData(indexName, testRecordsFile) { | |||
| } | |||
| } | |||
|
|
|||
| def generatefailedTestJson(componentName, componentRepo, componentRepoUrl, version, | |||
There was a problem hiding this comment.
nit:
| def generatefailedTestJson(componentName, componentRepo, componentRepoUrl, version, | |
| def generateFailedTestJson(componentName, componentRepo, componentRepoUrl, version, |
|
Thanks @peterzhuamazon and @gaiksaya, I have updated the requested changes in my latest commit. |
| def match = failedTest.split("#") | ||
| if (match) { | ||
| def testResultJsonContent = generateFailedTestJson(componentName, componentRepo, componentRepoUrl, version, integTestBuildNumber, | ||
| integTestBuildUrl, distributionBuildNumber, distributionBuildUrl, buildStartTime, rc, rcNumber, | ||
| platform, architecture, distribution, componentCategory, securityType, match[0].trim(), match[1].trim()) |
There was a problem hiding this comment.
Did not get this part. How are we splitting based on #?
There was a problem hiding this comment.
Ya this for splitting test_class#test_name, I have added a small test for both OpenSearch and Dashboards.
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Ya I forgot to update the tests when changed to sentence |
|
Merging this as the Mend Base branch commit: 4e94ed7991c7192faa94996988c1deacb8b9ec98, coming from #531. @gaiksaya @peterzhuamazon |
Description
Publish the failing test's name and class along with the integration test results.
Issues Resolved
Part of opensearch-project/opensearch-metrics#68 and #535.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.