Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs for ml-model runners #719

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

gkamat
Copy link
Collaborator

@gkamat gkamat commented Dec 27, 2024

Description

Some of the URL paths in change 794e11ed6 were missing a slash character.

Issues Resolved

#718

Testing

Ran the workload described in the issue.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Govind Kamat <govkamat@amazon.com>
Copy link
Member

@OVI3D0 OVI3D0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming this missing slash is resulting in broken URL's

@gkamat
Copy link
Collaborator Author

gkamat commented Jan 2, 2025

LGTM. Assuming this missing slash is resulting in broken URL's

Yes, noted in the associated issue.

@gkamat gkamat merged commit fd9bd49 into opensearch-project:main Jan 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants