Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Jinja filter to aid with version checking #599

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

gkamat
Copy link
Collaborator

@gkamat gkamat commented Jul 26, 2024

Description

Customizing workloads to operate differently on different versions of OpenSearch is convoluted. This change adds a Jinja filter version_between that can be used to test if an OpenSearch version falls within a specified range of versions. For instance, a workload can be customized to operate in a backward-compatible way on OpenSearch 1.X and use updated capabilities on OpenSearch 2.X.

Issues Resolved

#548

Testing

Added a test, ran unit and integ tests.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Govind Kamat <govkamat@amazon.com>
@gkamat gkamat force-pushed the jinja-ver-filter branch from 25a5f09 to c1bebd1 Compare July 26, 2024 16:13
Copy link
Collaborator

@IanHoang IanHoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer than the legacy format specified in the issue. Thanks for doing this!

@IanHoang IanHoang merged commit f12c9c0 into opensearch-project:main Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants