Excluding opensearch-benchmarkd process while finding benchmark process #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, /proc/PID/status truncates the command name to 15 characters which matches both opensearch-benchmark and opensearch-benchmarkd. Adding an additional check to exclude opensearch-benchmarkd process. Signed-off-by: Prabhakar Sithanandam <prabhakar.s87@gmail.com>
backslasht
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
gkamat
reviewed
Jun 14, 2024
finnroblin
pushed a commit
to finnroblin/opensearch-benchmark
that referenced
this pull request
Jul 19, 2024
…ss (opensearch-project#552) Signed-off-by: Prabhakar Sithanandam <prabhakar.s87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Linux, /proc/PID/status truncates the command name to 15 characters which matches both opensearch-benchmark and opensearch-benchmarkd. Adding an additional check to exclude opensearch-benchmarkd process.
Testing
Validated by running benchmark daemon on three nodes and then by running execute test with
--load-worker-coordinator-hostsoption. The test ran fine on the worker nodes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.