Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #54

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

VachaShah
Copy link
Collaborator

Description

Updating repo documentation and adding maintainers

Issues Resolved

Closes #51

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah force-pushed the update-documentation branch from 0f8a6c0 to 02f4ec2 Compare November 4, 2022 21:06
Copy link
Collaborator

@harshavamsi harshavamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update CODEOWNERS as well?

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah
Copy link
Collaborator Author

Can we update CODEOWNERS as well?

Added.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah requested a review from harshavamsi November 8, 2022 18:38
Copy link
Collaborator

@harshavamsi harshavamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harshavamsi
Copy link
Collaborator

@VachaShah do we want to make this 2PR approval?

@VachaShah VachaShah merged commit c42554e into opensearch-project:main Nov 8, 2022
@VachaShah VachaShah deleted the update-documentation branch November 8, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing MAINTAINERS.md file
2 participants