Skip only known or hidden files. #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
dblock
force-pushed
the
skip-only-known-files
branch
from
6b39dd7 to
92b65b9
Compare
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
skip-only-known-files
branch
from
92b65b9 to
c3fb570
Compare
Changes AnalysisCommit SHA: c3fb570 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10357434789/artifacts/1803243787 API Coverage
|
Spec Test Coverage Analysis
|
|
lol, how I first had it :) |
Amen. |
Xtansia
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the unfortunate side effects of #473 is that it's very easy to miss a test file that is misnamed. For example in #497 we have .yml, or files that aren't yml at all but get skipped.
In this PR we only skip known and hidden things.
cc: @awick
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.