Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprint1: combine PR for visualization from Sprint1 #818

Closed
wants to merge 77 commits into from
Closed

Sprint1: combine PR for visualization from Sprint1 #818

wants to merge 77 commits into from

Conversation

abasatwar
Copy link
Contributor

@abasatwar abasatwar commented Jun 24, 2022 •
edited
Loading

This PR includes below enhancements of visualizations-
[Enhancement]: UI for dimension and metrics #797
[Enhancement]: Time Series - Visualizations config panel features v1 #794
[ENHANCEMENT]: Heatmap visualization config panel features v1 #791
[ENHANCEMENT]: Pie visualization config panel features v1 - #793
Table View Enhancement for Visualization #772

@rinku-kumar-psl
graph style section UI schema
ed78cff 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
@rinku-kumar-psl
changes for style mode and interpolation
5f8ed2b 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts
@rinku-kumar-psl
lineWidth integration for line mode
3da4b49 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx
@rinku-kumar-psl
changes for Legend and Orientation in Line
4a4207c 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx
@rinku-kumar-psl
point size and Bar Alignment changes
790b33b 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/common/types/explorer.ts
@rinku-kumar-psl
implemented fill opacity for line chart
b5a6191 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx
@rinku-kumar-psl
changes for line width and fill opacity in bar mode and removed mode …
bae6b96 
…from chartOption

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
@rinku-kumar-psl
updated bar mode opacity in line chart
c91c934 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
@rinku-kumar-psl
refactored the config chart style code
30e7e88 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/common/types/explorer.ts
@rinku-kumar-psl
snapshot updated and code refactored
6e399da 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx
@rinku-kumar-psl
type added to new component
8235008 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx
@rinku-kumar-psl
review comments addressed
68fd32a 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
@rinku-kumar-psl
cypress test case added and resolve button label wraping issue
f2d3d32 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js
#	dashboards-observability/.cypress/utils/event_constants.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js
@rinku-kumar-psl
multi matrices changes for Line
a76ac36 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
@rinku-kumar-psl
dimensions and metrics UI changes for time-series
23373a1 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/common/constants/explorer.ts
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx
@rinku-kumar-psl
made data config pannel collapsable and initial fields render
988e761 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx
@rinku-kumar-psl
code refactored
2cb28f7 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
@rinku-kumar-psl
snapshot updated and handled corner cases
e632d77 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
@rinku-kumar-psl
code styling fixes and added TODO comment
dbd564e 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
@abasatwar abasatwar requested a review from a team as a code owner June 24, 2022 14:07
@abasatwar abasatwar changed the title Sprint1: combine PR for visualization Sprint1: combine PR for visualization from Sprint1 Jun 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022 •
edited
Loading

Codecov Report

Merging #818 (ea86f41) into main (c136532) will increase coverage by 4.98%.
The diff coverage is 35.56%.

@@             Coverage Diff              @@
##               main     #818      +/-   ##
============================================
+ Coverage     52.24%   57.22%   +4.98%     
- Complexity        0      291     +291     
============================================
  Files           213      259      +46     
  Lines          6054     8503    +2449     
  Branches       1567     1843     +276     
============================================
+ Hits           3163     4866    +1703     
- Misses         2856     3461     +605     
- Partials         35      176     +141
Flag Coverage Δ
dashboards-observability 51.76% <35.56%> (-0.49%) ⬇️
opensearch-observability 71.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/visualizations/charts/maps/heatmap.tsx 10.71% <0.00%> (+0.71%) ⬆️
...ponents/visualizations/charts/maps/heatmap_type.ts 100.00% <ø> (ø)
...panes/config_controls/config_line_chart_styles.tsx 3.33% <3.33%> (ø)
...alizations/charts/data_table/data_table_footer.tsx 10.00% <10.00%> (ø)
...alizations/charts/data_table/data_table_header.tsx 11.76% <11.76%> (ø)
...ts/visualizations/charts/data_table/data_table.tsx 43.07% <40.98%> (-19.79%) ⬇️
...oards-observability/common/constants/data_table.ts 100.00% <100.00%> (ø)
...nfig_panes/config_controls/config_button_group.tsx 100.00% <100.00%> (ø)
.../public/components/event_analytics/utils/utils.tsx 40.15% <100.00%> (ø)
...ic/components/visualizations/charts/lines/line.tsx 73.84% <100.00%> (+14.75%) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c136532...ea86f41. Read the comment docs.

@deepaknevdepsl deepaknevdepsl mentioned this pull request Jun 28, 2022
Closed
3 tasks
@ramneet-persistent @abasatwar
table view: eui table replaced with ag-grid
8e6769d 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
@ramneet-persistent @abasatwar
drag-drop issue fixed
6789e81 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
@ramneet-persistent @abasatwar
test case of data_table updated
546130e 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
@ramneet-persistent @abasatwar
feedback comments resolved
3b54ee0 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
@ramneet-persistent @abasatwar
grid height issue:fixed
4fbef03 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
@ramneet-persistent @abasatwar
column height, value getter for type double
61ed1b0 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
@ramneet-persistent @abasatwar
data_table elements moved to separate
5a231a4 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
rinku-kumar-psl and others added 28 commits June 29, 2022 15:40
@rinku-kumar-psl @abasatwar
type added to new component
8a1ff76 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
review comments addressed
ca5fb7b 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
cypress test case added and resolve button label wraping issue
dbde26d 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js
#	dashboards-observability/.cypress/utils/event_constants.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
multi matrices changes for Line
afe4f8b 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
dimensions and metrics UI changes for time-series
8d85495 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/common/constants/explorer.ts
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
made data config pannel collapsable and initial fields render
5eb9f4d 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
code refactored
12107ca 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
snapshot updated and handled corner cases
8cd4d1d 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@rinku-kumar-psl @abasatwar
code styling fixes and added TODO comment
2699c62 
Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
table view: eui table replaced with ag-grid
331faf0 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
drag-drop issue fixed
bc8d22b 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
test case of data_table updated
f79f752 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
feedback comments resolved
d599436 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
grid height issue:fixed
e7edb3f 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
column height, value getter for type double
3284da4 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
data_table elements moved to separate
a890546 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
footer components
8463572 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ramneet-persistent @abasatwar
cypress test cases for table view
daa2361 
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@deepaknevdepsl @abasatwar
data config reviewed code added
396e66c 
Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@deepaknevdepsl @abasatwar
Text correction
b4892c5 
Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@deepaknevdepsl @abasatwar
Conflicts resolved
c3a01fd 
Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@abasatwar
enhancement for heatmap with new UI
e286b4b 
Signed-off-by: Shankha Das <shankha.das@domo.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@abasatwar
line chart test cases
594af32 
Signed-off-by: Shankha Das <shankha.das@domo.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@abasatwar
console logs removed
4f3aadc 
Signed-off-by: Shankha Das <shankha.das@domo.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@mrunal-z @abasatwar
updated value options ui for treemap
e949ba4 
Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@mrunal-z @abasatwar
removed console
a335851 
Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@ruchika-narang @abasatwar
Fixes of sprint1 for new ui implementation (#12)
43c9e8d 
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: abasatwar <amruta_basatwar@persistent.com>
@abasatwar
Merge branch 'sprint1' of https://github.com/abasatwar/observability …
71ad174 
…into sprint1
@abasatwar
Copy link
Contributor Author

Fixed DCO check in this PR - #824.
Hence closing this one.

@abasatwar abasatwar closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abasatwar @codecov-commenter @rinku-kumar-psl @ramneet-persistent @deepaknevdepsl @mrunal-z @ruchika-narang