Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] Update availabilityVizId if visualization is removed from panel #738

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 291d17f from #732

Signed-off-by: Eugene Lee <eugenesk@amazon.com>
(cherry picked from commit 291d17f)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner May 17, 2022 16:49
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #738 (c5f9973) into 2.0 (b0ee26c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.0     #738      +/-   ##
============================================
- Coverage     59.50%   59.50%   -0.01%     
  Complexity      283      283              
============================================
  Files           237      237              
  Lines          7755     7756       +1     
  Branches       1593     1593              
============================================
  Hits           4615     4615              
- Misses         2966     2967       +1     
  Partials        174      174              
Flag Coverage Δ
dashboards-observability 52.92% <0.00%> (-0.01%) ⬇️
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lic/components/custom_panels/custom_panel_view.tsx 54.54% <ø> (ø)
...tom_panels/panel_modules/panel_grid/panel_grid.tsx 73.46% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ee26c...c5f9973. Read the comment docs.

@joshuali925
Copy link
Member

duplicated of #740, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants