Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented drop-down autocomplete using EuiSuggest #65

Conversation

sejli
Copy link
Member

@sejli sejli commented Jul 8, 2021

Description

Search bar has a very simple dropdown autosuggest feature in the Observability Event Explorer.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions

public/components/common/seach/queryBar.tsx Outdated Show resolved Hide resolved
public/components/common/seach/queryBar.tsx Outdated Show resolved Hide resolved
public/components/common/seach/queryBar.tsx Outdated Show resolved Hide resolved
public/components/common/seach/queryBar.tsx Outdated Show resolved Hide resolved
public/components/common/seach/queryBar.tsx Outdated Show resolved Hide resolved
Li added 4 commits July 9, 2021 13:04
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
…/trace-analytics into feature/autocomplete

Getting latest changes from feature/observability
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
…ndices after source)

Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
Li added 13 commits July 14, 2021 12:21
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
…nalytics page to crash

Signed-off-by: Sean Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
…ndices after source)

Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Li <lnse@88665a2fa6f9.ant.amazon.com>
…nalytics page to crash

Signed-off-by: Sean Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: Sean Li <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
sejli added 7 commits July 20, 2021 15:33
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
Signed-off-by: sejli <lnse@88665a2fa6f9.ant.amazon.com>
@sejli sejli closed this Jul 30, 2021
joshuali925 added a commit to joshuali925/observability that referenced this pull request Sep 8, 2021
* Correct URL link

* Bump ini from 1.3.5 to 1.3.8

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Joshua <joshuali925@gmail.com>
Co-authored-by: Kyle Davis <kyledvs@amazon.com>
Co-authored-by: Anirudha (Ani) Jadhav <jadhanir@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
joshuali925 added a commit to joshuali925/observability that referenced this pull request Sep 8, 2021
joshuali925 pushed a commit to joshuali925/observability that referenced this pull request Jul 20, 2022
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants