Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lower margin of autocomplete being cut off #512

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Fix lower margin of autocomplete being cut off #512

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05783d4
Fix lower margin of autocomplete being cut off
eugenesk24 Feb 28, 2022
165b876
Update snapshots
eugenesk24 Feb 28, 2022
a44cea8
Nest specific style and use shared styling
eugenesk24 Mar 1, 2022
7ad07a5
Update snapshots
eugenesk24 Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions dashboards-observability/public/components/application_analytics/app_analytics.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,31 @@
* SPDX-License-Identifier: Apache-2.0
*/

.ppl-link {
.ppl-create-link {
border: unset;
position: absolute;
top: 103px;
right: 140px;
background-color: transparent;
}
.ppl-link-light {
.ppl-create-link-light {
color: #006BB4;
}

.ppl-link-dark {
.ppl-create-link-dark {
color: #1BA9F5;
}

.query-area {
width: 900px;
}

#logSource {
overflow: visible;
position: relative;
z-index: 10;
}

#baseQueryCallout {
max-width: 900px;
}
15 changes: 6 additions & 9 deletions ...ility/public/components/application_analytics/components/config_components/log_config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const LogConfig = (props: LogConfigProps) => {
>
<EuiFlexGroup direction="column" gutterSize="s">
<EuiFlexItem>
<EuiCallOut iconType={'iInCircle'} size="s" style={{ maxWidth: '900px' }}>
<EuiCallOut id="baseQueryCallout" iconType={'iInCircle'} size="s">
You can&apos;t change the base query after the application is created.
</EuiCallOut>
</EuiFlexItem>
Expand All @@ -119,12 +119,7 @@ export const LogConfig = (props: LogConfigProps) => {
label="Base Query"
helpText="The default logs view in the application will be filtered by this query."
>
<EuiFlexItem
grow={false}
key="query-bar"
className="query-area"
style={{ minWidth: '900px' }}
>
<EuiFlexItem grow={false} key="query-bar" className="query-area">
<Autocomplete
key={'autocomplete-bar'}
query={query}
Expand All @@ -139,8 +134,10 @@ export const LogConfig = (props: LogConfigProps) => {
tabId={'application-analytics-tab'}
/>
<EuiBadge
className={`ppl-link ${
uiSettingsService.get('theme:darkMode') ? 'ppl-link-dark' : 'ppl-link-light'
className={`ppl-create-link ${
uiSettingsService.get('theme:darkMode')
? 'ppl-create-link-dark'
: 'ppl-create-link-light'
}`}
color="hollow"
onClick={() => showFlyout()}
Expand Down
16 changes: 6 additions & 10 deletions dashboards-observability/public/components/common/search/autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,9 @@ export const Autocomplete = (props: AutocompleteProps) => {
return (
<div
key={`scrollable-${index}`}
className="aa-PanelLayout aa-Panel--scrollable"
style={
uiSettingsService.get('theme:darkMode')
? { backgroundColor: '#1D1E24', border: '2px groove #383444' }
: {}
}
className={`aa-PanelLayout aa-Panel--scrollable ${
uiSettingsService.get('theme:darkMode') ? 'aa-Panel--scrollable-dark' : ''
}`}
>
<div key={`source-${index}`} className="aa-Source">
{items.length > 0 && (
Expand All @@ -158,14 +155,13 @@ export const Autocomplete = (props: AutocompleteProps) => {
return (
<li
key={item.__autocomplete_id}
className="aa-Item"
className={`aa-Item ${
uiSettingsService.get('theme:darkMode') ? 'aa-Item-dark' : ''
}`}
{...autocomplete.getItemProps({
item,
source,
})}
style={
uiSettingsService.get('theme:darkMode') ? { color: '#DFE5EF' } : {}
}
>
<div className="aa-ItemWrapper">
<div className="aa-ItemContent">
Expand Down
15 changes: 15 additions & 0 deletions dashboards-observability/public/components/common/search/search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
font-weight: bold;
}

#servicesEntities {
position: relative;
z-index: 0;
}

#autocomplete-textarea {
width: 100%;
outline: none;
Expand All @@ -30,11 +35,21 @@
font-size: 16px;
padding-right: 40px;
}

.aa-Panel {
width: 100%;
z-index: 2500;
}

.aa-Panel--scrollable-dark {
background-color: #1D1E24;
border: 2px groove #383444;
}

.aa-Item-dark {
color: #DFE5EF;
}

.event-date-picker {
max-width: 35vw;
}
Expand Down