Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebasing application analytics branch #358

Conversation

eugenesk24
Copy link
Contributor

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 and others added 9 commits December 13, 2021 14:32
* rebased with bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* tests

Signed-off-by: Eric Wei <menwe@amazon.com>

* updated some snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* resolved few failing tests

Signed-off-by: Eric Wei <menwe@amazon.com>

* few modifications

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* bumping version to 1.2.2

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update PR in release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
* Add database schema for application

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Finished front end for Application overview
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Finished application detail page tabs
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* WIP: Overview Page
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Rough sketch of App Analytics UI
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Create dummy page
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Create app complete. Stabilizing dashboard component.
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update to 1.2 Observability

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* notebooks internal error

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Address comments on PR: copyright headers, indentation, unnecessary render props

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Set max width of app and event

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove optional after description

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Change to singular

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove count badge for log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#290: Change form row label to ppl base query

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#291: Change description and help text for log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Pass down proper props

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Resolve gradle error and module not found error

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Resolve kotlin errors

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Fix parsers

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add praseItemList

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Camelcase fields

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove whitespace, add copyright

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#292: Add autocomplete to Log Source accordion

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Lexicographic kotlin import

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add newline at end of files

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#293: Add service map to create page

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#304: Activate Clear All button for services

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#305: Add button to clear base query

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#295: Add eui combo box for trace groups

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Separate out configuration renders

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* debug adding filters traces

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#296: Add traces table to config

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Change from tsx to ts

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#309: Add page props and add app specific filters

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#308: Add button to clear trace groups

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#311: Allow services and traces to be selected

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove link to traces on table

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Disable clear all if nothing selected

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* disable clear all when no log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove comment, add style to constant, temporarily remove availability

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Address PR comments

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Revert type assignment

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update tests, builds and doc (opensearch-project#318)

* rebased with bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Fix errors and address comments

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#319: Disable create until required fields are filled out

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#329: Add missing field tool tip

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove unnecessary imports

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#320: Add clear modal for friction

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link
Collaborator

@kavithacm kavithacm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that the CI build is failing for backend, can you check the build.gradle file?

Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #358 (7056553) into application-analytics (feb3983) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             application-analytics     #358   +/-   ##
========================================================
  Coverage                    69.29%   69.29%           
  Complexity                     270      270           
========================================================
  Files                           82       82           
  Lines                         2918     2918           
  Branches                       343      343           
========================================================
  Hits                          2022     2022           
  Misses                         731      731           
  Partials                       165      165           
Flag Coverage Δ
dashboards-observability 63.87% <ø> (ø)
opensearch-observability 71.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb3983...7056553. Read the comment docs.

eugenesk24 and others added 10 commits December 21, 2021 16:24
* updated snapshot in workflow to 1.2.3

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* replaced variable with 1.2.3-snapshot

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* revert string to variable

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
* Add database schema for application

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Finished front end for Application overview
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Finished application detail page tabs
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* WIP: Overview Page
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Rough sketch of App Analytics UI
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Create dummy page
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Create app complete. Stabilizing dashboard component.
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update to 1.2 Observability

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* notebooks internal error

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Address comments on PR: copyright headers, indentation, unnecessary render props

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Set max width of app and event

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove optional after description

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Change to singular

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove count badge for log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#290: Change form row label to ppl base query

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#291: Change description and help text for log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Pass down proper props

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Resolve gradle error and module not found error

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Resolve kotlin errors

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Fix parsers

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add praseItemList

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Camelcase fields

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove whitespace, add copyright

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#292: Add autocomplete to Log Source accordion

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Lexicographic kotlin import

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add newline at end of files

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#293: Add service map to create page

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#304: Activate Clear All button for services

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#305: Add button to clear base query

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#295: Add eui combo box for trace groups

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Separate out configuration renders

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* debug adding filters traces

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#296: Add traces table to config

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Change from tsx to ts

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#309: Add page props and add app specific filters

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#308: Add button to clear trace groups

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#311: Allow services and traces to be selected

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove link to traces on table

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Disable clear all if nothing selected

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* disable clear all when no log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove comment, add style to constant, temporarily remove availability

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Address PR comments

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Revert type assignment

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update tests, builds and doc (opensearch-project#318)

* rebased with bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Fix errors and address comments

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#319: Disable create until required fields are filled out

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#329: Add missing field tool tip

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove unnecessary imports

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#320: Add clear modal for friction

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
* Add database schema for application

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Finished front end for Application overview
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Finished application detail page tabs
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* WIP: Overview Page
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Rough sketch of App Analytics UI
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Create dummy page
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Create app complete. Stabilizing dashboard component.
Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update to 1.2 Observability

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* notebooks internal error

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Address comments on PR: copyright headers, indentation, unnecessary render props

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Set max width of app and event

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove optional after description

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Change to singular

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove count badge for log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#290: Change form row label to ppl base query

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#291: Change description and help text for log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Pass down proper props

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Resolve gradle error and module not found error

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Resolve kotlin errors

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Fix parsers

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add praseItemList

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Camelcase fields

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove whitespace, add copyright

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#292: Add autocomplete to Log Source accordion

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Lexicographic kotlin import

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add newline at end of files

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#293: Add service map to create page

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#304: Activate Clear All button for services

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#305: Add button to clear base query

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#295: Add eui combo box for trace groups

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Separate out configuration renders

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* debug adding filters traces

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#296: Add traces table to config

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Change from tsx to ts

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#309: Add page props and add app specific filters

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#308: Add button to clear trace groups

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#311: Allow services and traces to be selected

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove link to traces on table

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Disable clear all if nothing selected

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* disable clear all when no log source

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove comment, add style to constant, temporarily remove availability

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Address PR comments

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Revert type assignment

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update tests, builds and doc (opensearch-project#318)

* rebased with bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated bwc tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Fix errors and address comments

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#319: Disable create until required fields are filled out

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#329: Add missing field tool tip

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove unnecessary imports

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* opensearch-project#320: Add clear modal for friction

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
* Remove unnecessary memoization

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add tests for create page

Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@eugenesk24 eugenesk24 merged commit 26df65f into opensearch-project:application-analytics Dec 22, 2021
joshuali925 pushed a commit to joshuali925/observability that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants