Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer fixes #216

Merged
merged 8 commits into from
Nov 10, 2021
Merged

Explorer fixes #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a36801b
changed to query fields
mengweieric Nov 9, 2021
26f9e9e
select/available fields duplicate issue fix and reformatting
mengweieric Nov 9, 2021
c01a317
Merge branch 'main' into explorer-fixes
mengweieric Nov 9, 2021
4108874
fixed issue - updating saved search not updating existing tab
mengweieric Nov 9, 2021
1f3109f
added refresh to datepicker
mengweieric Nov 10, 2021
eaa863e
updated saving
mengweieric Nov 10, 2021
9413e25
saved objects new changes
mengweieric Nov 10, 2021
8379fa7
Merge branch 'main' into explorer-fixes
mengweieric Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dashboards-observability/common/constants/explorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ export const TAB_EVENT_ID_TXT_PFX = 'main-content-events-';
export const TAB_CHART_ID_TXT_PFX = 'main-content-vis-';
export const HAS_SAVED_TIMESTAMP = 'hasSavedTimestamp';
export const FILTER_OPTIONS = ['Visualization', 'Query'];
export const SAVED_QUERY = 'savedQuery';
export const SAVED_VISUALIZATION = 'savedVisualization';
export const SAVED_OBJECT_ID = 'savedObjectId';
export const SAVED_OBJECT_TYPE = 'objectType';

export const DATE_PICKER_FORMAT = 'YYYY-MM-DD HH:mm:ss';
export const TIME_INTERVAL_OPTIONS = [
Expand Down
5 changes: 2 additions & 3 deletions dashboards-observability/public/components/common/search/date_picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ export function DatePicker(props: IDatePickerProps) {
style={{maxWidth: '40vw'}}
>
<EuiSuperDatePicker
start={ startTime }
end={ endTime }
showUpdateButton={ false }
start={startTime}
end={endTime}
dateFormat={uiSettingsService.get('dateFormat')}
onTimeChange={(e) => {
const start = e.start;
Expand Down
1 change: 0 additions & 1 deletion dashboards-observability/public/components/common/search/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import { DatePicker } from './date_picker';
import '@algolia/autocomplete-theme-classic';
import { Autocomplete } from './autocomplete';
import { SavePanel } from '../../explorer/save_panel';
import { useCallback } from 'react';
import { PPLReferenceFlyout } from '../helpers';

export interface IQueryBarProps {
Expand Down
2 changes: 1 addition & 1 deletion dashboards-observability/public/components/explorer/docTable/docViewRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const DocViewRow = (props: IDocViewRowProps) => {
key={ uniqueId('datagrid-cell-') }
className={ clsName }
>
{ content }
{ typeof(content) === 'boolean' ? String(content) : content }
</td>);
};

Expand Down
5 changes: 4 additions & 1 deletion dashboards-observability/public/components/explorer/event_analytics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { EuiGlobalToastList } from '@elastic/eui';
import { Toast } from '@elastic/eui/src/components/toast/global_toast_list';
import { isEmpty } from 'lodash';
import React, { ReactChild, useState } from 'react';
import { HashRouter, Route, Switch } from 'react-router-dom';
import { HashRouter, Route, Switch, useHistory } from 'react-router-dom';
import { RAW_QUERY } from '../../../common/constants/explorer';
import { ObservabilitySideBar } from '../common/side_nav';
import { Home as EventExplorerHome } from './home';
Expand All @@ -29,6 +29,7 @@ export const EventAnalytics = ({
http,
...props
}: any) => {
const history = useHistory();
const [toasts, setToasts] = useState<Array<Toast>>([]);

const eventAnalyticsBreadcrumb = {
Expand Down Expand Up @@ -86,6 +87,7 @@ export const EventAnalytics = ({
setToast={setToast}
chrome={chrome}
getExistingEmptyTab={getExistingEmptyTab}
history={history}
/>
);
}}
Expand All @@ -111,6 +113,7 @@ export const EventAnalytics = ({
timestampUtils={timestampUtils}
setToast={setToast}
getExistingEmptyTab={getExistingEmptyTab}
history={history}
/>
</ObservabilitySideBar>
);
Expand Down
Loading