-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/p1 release #133
Merged
mengweieric
merged 22 commits into
opensearch-project:feature/observability
from
mengweieric:feature/p1-release
Oct 14, 2021
Merged
Feature/p1 release #133
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c2a5647
removed live button
mengweieric 53f2057
refresh button
mengweieric bf6daf6
removed live button from home
mengweieric 493a334
xaxis range selectable
mengweieric 4cf83bb
added new charts
mengweieric a5d3b3b
added sidebar to vis, hided vis setting panel
mengweieric 2e6a1e8
fixed a bar issue
mengweieric 4cb8b73
modified run/refresh button
mengweieric 99fd853
hided surrounding docs
mengweieric 5c2eb10
disabled insights
mengweieric f03d6bd
disable reset button and remove s/ms options
mengweieric 2809609
breadcrumb/route changes
mengweieric 460411a
add date range to query & added runtime fields
mengweieric 5655570
disabled toggle button for queried fields
mengweieric 482129a
modified text
mengweieric 5088c9e
added couple of configs to autocomplete
mengweieric c2f1681
Merge branch 'feature/observability' into feature/p1-release
mengweieric 2f3370d
merged custom panel
mengweieric c43aacd
added saved objects and few bug fixes
mengweieric 5e8e377
removed unused reference/files, modified few loggings
mengweieric b94d2cd
removed missed comments/usused code, fixed one sidebar issue
mengweieric 3bee70a
modified files for code review
mengweieric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you select something like
Today
orThis week
from date picker's "commonly used", i rememberstartTime
andendTime
will be the same string. could you check if you need to do some handling for thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, on handler side, I added the code to check and change the end to be 'now' if start and end are the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mengweieric i think instead of changing it to
now
, you can usedatemath.parse(endTime, {roundUp: true})
so something like "Today" will also includenow
to end of day. Ref: https://github.com/elastic/kibana/blob/master/packages/elastic-datemath/src/index.ts#L157There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this makes sense, I'll change it.