Use in-memory count for total hits in patterns ratio #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
mengweieric
approved these changes
Nov 4, 2022
derek-ho
reviewed
Nov 4, 2022
| } | ||
|
|
||
| export function PatternsTable(props: PatternsTableProps) { | ||
| const { tableData, tabId, onPatternSelection, query } = props; | ||
| const patternsData = useSelector(selectPatterns)[tabId]; |
There was a problem hiding this comment.
was patternsData just never used?
There was a problem hiding this comment.
patternsData used to contain the results of stats count() as total hit, forgot to remove it since i removed stats count() call
derek-ho
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li joshuali925@gmail.com
Description
Patterns was using total hits from hits counter since prometheus doesn't support
stats count(), but hits counter will refresh if filtered by pattern, and the ratio becomes incorrect.Issues Resolved
closes #1251
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.