Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics bug fixes #1 #1248

Merged
merged 1 commit into from
Nov 4, 2022
Merged

metrics bug fixes #1 #1248

merged 1 commit into from
Nov 4, 2022

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Nov 4, 2022

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

Description

  1. Add validation for span interval input
  2. Toast for span interval input
  3. Show modal for catalog visualization container
  4. Re-add cancel button in edit mode
  5. Fix top panel edit mode issue
  6. Update span regex

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 requested a review from a team as a code owner November 4, 2022 01:44
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #1248 (6f511f8) into 2.4 (e88ab44) will increase coverage by 0.00%.
The diff coverage is 58.82%.

@@            Coverage Diff            @@
##                2.4    #1248   +/-   ##
=========================================
  Coverage     54.58%   54.59%           
  Complexity      292      292           
=========================================
  Files           283      283           
  Lines          9804     9813    +9     
  Branches       2299     2301    +2     
=========================================
+ Hits           5352     5357    +5     
- Misses         4281     4285    +4     
  Partials        171      171           
Flag Coverage Δ
dashboards-observability 49.52% <58.82%> (+<0.01%) ⬆️
opensearch-observability 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...isualization_container/visualization_container.tsx 67.27% <56.25%> (-2.30%) ⬇️
.../public/components/custom_panels/helpers/utils.tsx 72.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ps48 ps48 merged commit bfda43a into opensearch-project:2.4 Nov 4, 2022
@ps48 ps48 changed the title metrics bug fixes #1 metrics bug fixes #1 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants