Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics visualization regression fix #1244

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Nov 4, 2022

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

Description

Fixes visualization regression issue in metrics

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 requested a review from a team as a code owner November 4, 2022 00:11
@codecov-commenter
Copy link

Codecov Report

Merging #1244 (6bf692a) into 2.4 (330a117) will increase coverage by 15.69%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.4    #1244       +/-   ##
=============================================
+ Coverage     54.66%   70.35%   +15.69%     
  Complexity      292      292               
=============================================
  Files           283       42      -241     
  Lines          9789     2392     -7397     
  Branches       2296      248     -2048     
=============================================
- Hits           5351     1683     -3668     
+ Misses         4267      568     -3699     
+ Partials        171      141       -30     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 70.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../public/components/custom_panels/helpers/utils.tsx
...ublic/components/visualizations/charts/pie/pie.tsx
...ic/components/visualizations/charts/lines/line.tsx
...onents/trace_analytics/requests/request_handler.ts
...ent_analytics/explorer/events_views/doc_flyout.tsx
...vent_analytics/explorer/events_views/docViewer.tsx
..._analytics/components/traces/span_detail_panel.tsx
..._panes/config_controls/config_bar_chart_styles.tsx
...event_analytics/explorer/save_panel/save_panel.tsx
...analytics/components/services/services_content.tsx
... and 231 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ps48 ps48 merged commit e88ab44 into opensearch-project:2.4 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants