Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Data Configuration panel for Logs view remains disabled. #1057

Merged
merged 9 commits into from
Sep 30, 2022

Conversation

saisanju-s
Copy link
Contributor

@saisanju-s saisanju-s commented Sep 30, 2022

Description

  1. Data configuration panel for Logs view remains incorrectly enabled or disabled.
  2. Data configuration does not render fields correctly as per PPL query.
  3. Time stamp field not getting listed in data configuration panel.

Issues Resolved

#1040

Check List

  • New functionality includes logs view visualization fixes mentioned above.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ruchika-narang and others added 9 commits September 30, 2022 14:51
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
…ashes in app

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: Saisanju Sreevalsakumar <saisanju_s@persistent.com>
Signed-off-by: Saisanju Sreevalsakumar <saisanju_s@persistent.com>
@saisanju-s saisanju-s requested a review from a team as a code owner September 30, 2022 13:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #1057 (22edf49) into main (bdf5291) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1057      +/-   ##
============================================
- Coverage     53.60%   53.57%   -0.03%     
  Complexity      291      291              
============================================
  Files           280      280              
  Lines          9309     9314       +5     
  Branches       2135     2135              
============================================
  Hits           4990     4990              
- Misses         4149     4154       +5     
  Partials        170      170              
Flag Coverage Δ
dashboards-observability 47.53% <0.00%> (-0.04%) ⬇️
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/visualizations/charts/helpers/viz_types.ts 32.00% <0.00%> (-1.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup changes addressing previous comments.

@mengweieric mengweieric merged commit e9ff79a into opensearch-project:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants