Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match core wizard design #1044

Merged

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Sep 27, 2022

Description

Step 1 for aligning common UX design with core team's for Observability visualizations.

Preview screenshot

Screen Shot 2022-09-26 at 4 38 58 PM

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot bot and others added 30 commits March 10, 2022 12:55
…search-project#508) (opensearch-project#574)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.25.0...v1.27.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit b4f491a)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…) (opensearch-project#576)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 5c43e9d)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
)

Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric requested a review from a team as a code owner September 27, 2022 06:05
@mengweieric mengweieric changed the title Feature/match core design Match core wizard design Sep 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #1044 (210918a) into main (3ce8d87) will decrease coverage by 0.00%.
The diff coverage is 88.23%.

@@             Coverage Diff              @@
##               main    #1044      +/-   ##
============================================
- Coverage     54.31%   54.31%   -0.01%     
  Complexity      291      291              
============================================
  Files           278      277       -1     
  Lines          9113     9106       -7     
  Branches       2038     2034       -4     
============================================
- Hits           4950     4946       -4     
+ Misses         3992     3990       -2     
+ Partials        171      170       -1     
Flag Coverage Δ
dashboards-observability 48.34% <88.23%> (-0.01%) ⬇️
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ic/components/common/field_button/field_button.tsx 63.63% <ø> (ø)
...ponents/event_analytics/explorer/sidebar/field.tsx 69.76% <ø> (ø)
...ublic/components/visualizations/charts/bar/bar.tsx 12.00% <ø> (ø)
...lorer/visualizations/config_panel/config_panel.tsx 68.75% <33.33%> (ø)
...public/components/common/field_icon/field_icon.tsx 100.00% <100.00%> (ø)
...nents/event_analytics/explorer/sidebar/sidebar.tsx 88.46% <100.00%> (+7.81%) ⬆️
...ts/visualizations/charts/financial/gauge/gauge.tsx 29.57% <100.00%> (+1.00%) ⬆️
...isualizations/config_panel/config_panel_footer.tsx

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric merged commit 08a8d82 into opensearch-project:main Sep 27, 2022
@mengweieric mengweieric deleted the feature/match-core-design branch September 27, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants