Skip to content

Commit

Permalink
[Feature]: Heatmap 2way sync (#1031)
Browse files Browse the repository at this point in the history
* Heatmap doesnt render if more than 1 metric or 2 dimensions are added

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* Test cases resolution

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* Eliminated unnecessary commented code

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>
  • Loading branch information
DipraAich authored Sep 19, 2022
1 parent 46b26c5 commit e05fb74
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ export const HeatMap = ({ visualizations, layout, config }: any) => {
isEmpty(zMetrics) ||
isEmpty(data[xaxisField.label]) ||
isEmpty(data[yaxisField.label]) ||
isEmpty(data[`${zMetrics.aggregation}(${zMetrics.name})`])
// indexOf(NUMERICAL_FIELDS, zMetrics.type) < 0
isEmpty(data[`${zMetrics.aggregation}(${zMetrics.name})`]) ||
dataConfig?.dimensions.length > 2 ||
dataConfig?.metrics.length > 1
)
return <EmptyPlaceholder icon={visualizations?.vis?.icontype} />;

Expand Down

0 comments on commit e05fb74

Please sign in to comment.