removed inputType, merged both viz options

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
opensearch-project · Dec 16, 2021 · ccd2757 · ccd2757
1 parent 56b60a1
commit ccd2757
Show file tree

Hide file tree

Showing 19 changed files with 479 additions and 422 deletions.
diff --git a/dashboards-observability/.cypress/CYPRESS_TESTS.md b/dashboards-observability/.cypress/CYPRESS_TESTS.md
@@ -102,7 +102,8 @@ The observability plugin currently has 4 modules in it. Each of the modules have
 * Renders input only mode
 * Renders output only mode
 * Duplicates paragraphs
-* Adds a visualization paragraph
+* Adds a dashboards visualization paragraph
+* Adds an observability visualization paragraph
 * Adds a SQL query paragraph
 * Adds a PPL query paragraph
 * Clears outputs

diff --git a/dashboards-observability/.cypress/integration/notebooks.spec.js b/dashboards-observability/.cypress/integration/notebooks.spec.js
@@ -258,7 +258,7 @@ describe('Testing paragraphs', () => {
   it('Adds a dashboards visualization paragraph', () => {
     cy.contains('Add paragraph').click();
     cy.wait(delay);
-    cy.get('.euiContextMenuItem__text').contains('Dashboards visualization').click();
+    cy.get('.euiContextMenuItem__text').contains('Visualization').click();
     cy.wait(delay);
 
     cy.get('.euiButton__text').contains('Run').click();
@@ -267,13 +267,12 @@ describe('Testing paragraphs', () => {
 
     cy.get('.euiButton__text').contains('Browse').click();
     cy.wait(delay);
-    cy.get('.euiFieldSearch').focus().type('{uparrow}{uparrow}{enter}');
+    cy.get('.euiFieldSearch').focus().type('[Flights] Flight Count and Average Ticket Price{enter}');
     cy.wait(delay);
     cy.get('.euiButton__text').contains('Select').click();
     cy.wait(delay);
     cy.get('.euiButton__text').contains('Run').click();
     cy.wait(delay);
-
     cy.get('div.visualization').should('exist');
   });
 
@@ -296,7 +295,7 @@ describe('Testing paragraphs', () => {
   it('Adds an observability visualization paragraph', () => {
     cy.contains('Add paragraph').click();
     cy.wait(delay);
-    cy.get('.euiContextMenuItem__text').contains('Observability visualization').click();
+    cy.get('.euiContextMenuItem__text').contains('Visualization').click();
     cy.wait(delay);
 
     cy.get('.euiButton__text').contains('Run').click();
@@ -305,14 +304,13 @@ describe('Testing paragraphs', () => {
 
     cy.get('.euiButton__text').contains('Browse').click();
     cy.wait(delay);
-    cy.get('.euiFieldSearch').focus().type('{uparrow}{uparrow}{enter}');
+    cy.get('.euiFieldSearch').focus().type('[Logs] Count total requests by tags{enter}');
     cy.wait(delay);
     cy.get('.euiButton__text').contains('Select').click();
     cy.wait(delay);
     cy.get('.euiButton__text').contains('Run').click();
     cy.wait(delay);
-
-    cy.get('div.visualization').should('exist');
+    cy.get('h5').contains('[Logs] Count total requests by tags').should('exist');
   });
 
   it('Adds a PPL query paragraph', () => {
@@ -368,7 +366,7 @@ describe('Testing paragraphs', () => {
     cy.get('.euiContextMenuItem__text').contains('Code block').click();
     cy.wait(delay);
 
-    cy.get('.euiText').contains('[4] OpenSearch Dashboards visualization').should('exist');
+    cy.get('.euiText').contains('[4] Visualization').should('exist');
     cy.get('.euiText').contains('[5] Code block').should('exist');
   });
 
@@ -379,7 +377,7 @@ describe('Testing paragraphs', () => {
     cy.get('.euiContextMenuItem__text').contains('Move to bottom').click();
     cy.wait(delay);
 
-    cy.get('.euiText').contains('[3] OpenSearch Dashboards visualization').should('exist');
+    cy.get('.euiText').contains('[3] Visualization').should('exist');
   });
 
   it('Duplicates and renames the notebook', () => {

diff --git a/dashboards-observability/common/constants/shared.ts b/dashboards-observability/common/constants/shared.ts
@@ -26,6 +26,7 @@ export const observabilityTitle = 'Observability';
 export const observabilityPluginOrder = 6000;
 
 // Shared Constants
+export const SQL_DOCUMENTATION_URL ='https://opensearch.org/docs/latest/observability-plugins/ppl/commands/'
 export const PPL_DOCUMENTATION_URL ='https://opensearch.org/docs/latest/observability-plugins/ppl/commands/'
 export const UI_DATE_FORMAT = 'MM/DD/YYYY hh:mm A';
 export const PPL_DATE_FORMAT = 'YYYY-MM-DD HH:mm:ss';

diff --git a/dashboards-observability/common/types/notebooks.ts b/dashboards-observability/common/types/notebooks.ts
@@ -35,7 +35,6 @@ export type ParaType = {
   isInputHidden: boolean;
   isOutputHidden: boolean;
   showAddPara: boolean;
-  inputType: string;
   isVizualisation: boolean;
   vizObjectInput: string;
   id: number;