Modify one alias in the CODEOWNERS file as it's been changed #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <gbinlong@amazon.com>
gaobinlong
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
zhichao-aws and
zhongnansu
as code owners
Hailong-am
previously approved these changes
Apr 26, 2023
zhichao-aws
previously approved these changes
Apr 26, 2023
|
Can you also update the MAINTAINERS.md file to reflect the users listed on this CODEOWNERS file? I have fixed the permissions based on the CODEOWNERS file so you can merge and close this PR once you update the MAINTAINERS.md file. |
|
@bbarani you mean all of the users in the CODEOWNERS file should also be listed in the MAINTAINERS file? |
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Hailong-am
approved these changes
May 9, 2023
|
@gaobinlong Yes, MAINTAINERS.md and CODEOWNERS should be in sync. |
|
CODEOWNERS is green now and I have fixed the permissions. Ready to merge once the CI passes. |
xluo-aws
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yuye has changed his alias in Github, so we should sync it in the CODEOWNERS file.
Issues Resolved
#616
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.