-
Notifications
You must be signed in to change notification settings - Fork 82
Fix custom webhook request body format #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom webhook request body format #248
Conversation
59f3d93 to
ad1353d
Compare
|
CI is failing, but it passed locally. I also try re-run CI on HEAD of |
Codecov Report
@@ Coverage Diff @@
## develop #248 +/- ##
========================================
Coverage 80.53% 80.53%
========================================
Files 60 60
Lines 1634 1634
Branches 415 415
========================================
Hits 1316 1316
Misses 310 310
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| import org.apache.http.impl.client.CloseableHttpClient | ||
| import org.apache.http.message.BasicStatusLine | ||
| import org.easymock.EasyMock | ||
| import org.junit.Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we changed the Test import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are using junit5, but this one is still junit4, it doesn't throw error, but actually the tests are not picked up. We should use junit 5 anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one question
Description
mainIssues Resolved
#245
#232
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.