Skip to content

Conversation

@AWSHurneyt
Copy link
Contributor

@AWSHurneyt AWSHurneyt commented Feb 20, 2025

Description

  1. Add alpha1 qualifier.
  2. Updated github workflow action versions.
  3. Update import using master (deprecated) to clusterManager.

Related Issues

opensearch-project/opensearch-build#3747

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt
Copy link
Contributor Author

@peterzhuamazon do you have any recommendations for how to get past this issue?

It looks like the package is failing to build due to the BWC tests.
https://github.com/opensearch-project/notifications/actions/runs/13511495391/job/37752464207?pr=1002#step:6:33

Could not determine the dependencies of task ':notifications:notificationsBwcCluster#fullRestartClusterTask'.
> Could not resolve all artifacts for configuration ':notifications:opensearchPlugin'.
   > Could not find org.opensearch.plugin:opensearch-notifications-core:2.20.0.0-SNAPSHOT.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/opensearch-notifications-core/2.20.0.0-SNAPSHOT/maven-metadata.xml
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/opensearch-notifications-core/2.20.0.0-SNAPSHOT/opensearch-notifications-core-2.20.0.0-SNAPSHOT.pom

The version that we use for our BWC tests is whatever version used by OS core 2.x branch.
https://github.com/opensearch-project/notifications/blob/main/notifications/notifications/build.gradle#L270

However, OpenSearch core bumped the 2.x branch to v2.20.
https://github.com/opensearch-project/OpenSearch/blob/2.x/buildSrc/version.properties#L1

@peterzhuamazon
Copy link
Member

@AWSHurneyt merge this: #992

Then wait for the sonatype snapshot to be published.

Thanks.

@peterzhuamazon
Copy link
Member

Hi @AWSHurneyt is this ready to merge now?

Thanks.

@AWSHurneyt
Copy link
Contributor Author

Hi @AWSHurneyt is this ready to merge now?

Thanks.

@peterzhuamazon I'm working on fixing the security test workflow currently. After some tweaking to that workflow, it's no longer running.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Contributor Author

The security test workflow needs to be refactored away from using a docker image (similar to PR opensearch-project/anomaly-detection#1414).

Need to troubleshoot the configuration more though; so will publish those changes in a subsequent PR rather than blocking this version bump for it.

The notification bump needs to be merged to unblock ISM, alerting, and security analytics plugins.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review February 25, 2025 22:15
@peterzhuamazon
Copy link
Member

Thanks @AWSHurneyt !

@peterzhuamazon peterzhuamazon merged commit 4b99387 into opensearch-project:main Feb 25, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants