fix microsoft teams sample url in IT to adapt url validation

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
opensearch-project · Aug 24, 2023 · 18c8af1 · 18c8af1
1 parent c330a1c
commit 18c8af1
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/notifications/notifications/src/test/kotlin/org/opensearch/integtest/IntegTestHelpers.kt b/notifications/notifications/src/test/kotlin/org/opensearch/integtest/IntegTestHelpers.kt
@@ -122,7 +122,7 @@ fun getCreateNotificationRequestJsonString(
             "chime":{"url":"https://chime.domain.com/sample_chime_url#$randomString"}
         """.trimIndent()
         ConfigType.MICROSOFT_TEAMS -> """
-            "microsoft_teams":{"url":"https://microsoftTeams.domain.com/sample_microsoft_teams_url#$randomString"}
+            "microsoft_teams":{"url":"https://microsoftTeams.domain.webhook.office.com/sample_microsoft_teams_url#$randomString"}
         """.trimIndent()
         ConfigType.WEBHOOK -> """
             "webhook":{"url":"https://web.domain.com/sample_web_url#$randomString"}

diff --git a/...tifications/src/test/kotlin/org/opensearch/integtest/config/CreateNotificationConfigIT.kt b/...tifications/src/test/kotlin/org/opensearch/integtest/config/CreateNotificationConfigIT.kt
@@ -106,7 +106,7 @@ class CreateNotificationConfigIT : PluginRestTestCase() {
     fun `test Create microsoft teams notification config with ID`() {
         // Create sample config request reference
         val configId = "sample_config_id"
-        val sampleMicrosoftTeams = MicrosoftTeams("https://domain.com/sample_microsoft_teams_url#1234567890")
+        val sampleMicrosoftTeams = MicrosoftTeams("https://domain.webhook.office.com/1234567")
         val referenceObject = NotificationConfig(
             "this is a sample config name",
             "this is a sample config description",

diff --git a/...src/test/kotlin/org/opensearch/integtest/config/MicrosoftTeamsNotificationConfigCrudIT.kt b/...src/test/kotlin/org/opensearch/integtest/config/MicrosoftTeamsNotificationConfigCrudIT.kt
@@ -19,7 +19,7 @@ class MicrosoftTeamsNotificationConfigCrudIT : PluginRestTestCase() {
 
     fun `test Create, Get, Update, Delete microsoft teams notification config using REST client`() {
         // Create sample config request reference
-        val sampleMicrosoftTeams = MicrosoftTeams("https://domain.com/sample_microsoft_teams_url#1234567890")
+        val sampleMicrosoftTeams = MicrosoftTeams("https://domain.webhook.office.com/webhook2/test")
         val referenceObject = NotificationConfig(
             "this is a sample config name",
             "this is a sample config description",
@@ -67,7 +67,7 @@ class MicrosoftTeamsNotificationConfigCrudIT : PluginRestTestCase() {
         Thread.sleep(100)
 
         // Updated notification config object
-        val updatedMicrosoftTeams = MicrosoftTeams("https://updated.domain.com/updated_microsoft_teams_url#0987654321")
+        val updatedMicrosoftTeams = MicrosoftTeams("https://updated.domain.webhook.office.com/webhook2/test")
         val updatedObject = NotificationConfig(
             "this is a updated config name",
             "this is a updated config description",
@@ -126,7 +126,7 @@ class MicrosoftTeamsNotificationConfigCrudIT : PluginRestTestCase() {
 
     fun `test Bad Request for multiple config data for microsoft teams using REST Client`() {
         // Create sample config request reference
-        val sampleMicrosoftTeams = MicrosoftTeams("https://domain.com/sample_microsoft_teams_url#1234567890")
+        val sampleMicrosoftTeams = MicrosoftTeams("https://domain.webhook.office.com/1234567")
         val referenceObject = NotificationConfig(
             "this is a sample config name",
             "this is a sample config description",

diff --git a/...tifications/src/test/kotlin/org/opensearch/integtest/send/SendTestMessageRestHandlerIT.kt b/...tifications/src/test/kotlin/org/opensearch/integtest/send/SendTestMessageRestHandlerIT.kt
@@ -89,7 +89,7 @@ internal class SendTestMessageRestHandlerIT : PluginRestTestCase() {
                 "config_type":"microsoft_teams",
                 "is_enabled":true,
                 "microsoft_teams":{
-                    "url":"https://hooks.microsft_teams.com/services/xxx/xxx"
+                    "url":"https://hooks.webhook.office.com/webhook2/abcde"
                 }
             }
         }