Enhance syntax for nested mapping in destination fields #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
Enhancements
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
force-pushed
the
new_syntax_for_nested_fields_mapping_at_destination
branch
from
5b1b74b
to
0cfedd6
Compare
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es,
vibrantvarun and
zhichao-aws
as code owners
heemin32
approved these changes
Jul 22, 2024
src/main/java/org/opensearch/neuralsearch/processor/InferenceProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
junqiu-lei
approved these changes
Jul 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Enhance syntax for nested mapping in destination fields Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 770a8ca)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Enhance syntax for nested mapping in destination fields Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 770a8ca)
martin-gaievski
added a commit
that referenced
this pull request
Jul 22, 2024
5 tasks
martin-gaievski
added a commit
that referenced
this pull request
Aug 7, 2024
* Enhance syntax for nested mapping in destination fields Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 770a8ca) Signed-off-by: Martin Gaievski <gaievski@amazon.com> Co-authored-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is continuation of enabling comma based syntax for nested fields in mapping definition for embedding processors. This PR is focused on adding new syntax for the destination field.
Example of the new format we going to support:
final ingest document will look like:
with today's code ingest document will look like:
Previous PR for source part of the mapping: #811
Issues Resolved
#110
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.