Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for request_cache flag in hybrid query #662

Closed
wants to merge 1 commit into from

Conversation

martin-gaievski
Copy link
Member

Description

In this PR we're relaxing validation of fetch and query results for case when request cache is enabled and index has 1 shard. Today's code throws exception in such scenario, this is because cached results of fetch and query are different in size.

Issues Resolved

#606

Check List

  • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch Bug Fixes Changes to a system or product designed to handle a programming bug/glitch v2.14.0 labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.04%. Comparing base (50a6dcf) to head (baa94ab).

Files Patch % Lines
...arch/processor/NormalizationProcessorWorkflow.java 33.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #662      +/-   ##
============================================
- Coverage     84.19%   84.04%   -0.15%     
- Complexity      743      744       +1     
============================================
  Files            59       59              
  Lines          2309     2313       +4     
  Branches        370      374       +4     
============================================
  Hits           1944     1944              
  Misses          214      214              
- Partials        151      155       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Bug Fixes Changes to a system or product designed to handle a programming bug/glitch v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant