Update neural_query_enricher bwc tests #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
zhichao-aws
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
============================================
+ Coverage 84.04% 84.19% +0.14%
+ Complexity 744 743 -1
============================================
Files 59 59
Lines 2313 2309 -4
Branches 374 370 -4
============================================
Hits 1944 1944
Misses 214 214
+ Partials 155 151 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
|
Looks good to me. |
vibrantvarun
approved these changes
Apr 9, 2024
...ng-upgrade/src/test/java/org/opensearch/neuralsearch/bwc/NeuralQueryEnricherProcessorIT.java
Show resolved
Hide resolved
martin-gaievski
approved these changes
Apr 9, 2024
zhichao-aws
added
the
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
* update neural_query_enricher bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * changelog Signed-off-by: zhichao-aws <zhichaog@amazon.com> * nit Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit 4b71e49)
zhichao-aws
added a commit
that referenced
this pull request
Apr 10, 2024
* update neural_query_enricher bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * changelog Signed-off-by: zhichao-aws <zhichaog@amazon.com> * nit Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit 4b71e49) Co-authored-by: zhichao-aws <zhichaog@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the backport PR of #614 get merged, we should update the bwc tests for neural_query_enricher neural_sparse search. Update the behavior of old cluster in version 2.13.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.